Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits

Paul E. McKenney
2019-08-27T15:25:14Z

On Tue, Aug 27, 2019 at 05:06:13PM +0200, Thomas Gleixner wrote:
> On Tue, 27 Aug 2019, Paul E. McKenney wrote:
> > On Tue, Aug 27, 2019 at 06:30:11AM -0700, Dmitry Vyukov via Ksummit-discuss wrote:
> > > If I am reading git help correctly, this won't handle changes with
> > > more than 1 version. Also maintainers will be prohibited from doing
> > > any changed to patches during commit.
> >
> > Or we are required to add more Link: tags or other annotations describing
> > what we changed and why.
>
> The point is that the Link: tag connects the commit to the email by
> which it was submitted.
>
> If the committer fixes something up when committing, then this still stays
> the same connection.
>
> So you have SHA1 + Message-ID. If the SHA1 changes and Message-ID stays
> then same, then either the patch was amended or rebased. But you can figure
> that out with diff.

So I "git am" a patch after running your tool, and it has "Link:". I run
tests, find a bug, and update the commit with a fix (which admittedly
is not the normal workflow). I can presumably keep doing what I do now:

[ paulmck: Fix blablabla due to rcutorture failure blablabla. ]

Someone then reviews the patch and reports a bug. I update the
commit with a fix. Now what I do is this:

[ paulmck: Update based on blablabla feedback from So And So. ]

I suppose I could add a second "Link:", which was what I was thinking
when responding to Dmitry's email. Sounds like I continue with the
"[ paulmck: blablabla ]" approach ;-)

Thanx, Paul