Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits

Sean Paul
2019-08-23T13:16:13Z

On Thu, Aug 22, 2019 at 11:04 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Thu, Aug 22, 2019 at 7:58 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > So yes, I'd *much* rather see that "Link" line than try to make a
> > "Change-ID" line be a thing.
>
> Tangential note: since it looks like "Link:" lines are going to get
> more common in general, maybe somebody with the right tck/tk-fu can
> make a tool like 'gitk' be able to just do the hyperlinking thing (it
> already does it for commit hashes in the commit message, but wouldn't
> it be convenient to do that for web links too and open a browser
> tab?).
>
> And maybe we can even make git.kernel.org do it too (I think that uses cgit?).
>
> I think that might make it just nicer in general to browse the logs
> and actually follow the links without cut-and-paste games..
>
> So using a generic "Link:" tag that can be used for multiple different
> things sounds like a win in general over some specialized change-ID
> tag. No?

Only if you've uploaded the patch somewhere before sending it to the
mailing list. I think this would satisfy the Gerrit crowd, since
they're presumably uploading the patch to Gerrit, getting some review
on it and then sending it upstream. They will have a link. If you're
just interested in being archival tool friendly, you probably just
want to add some uuid cookie to the patch and post it directly to the
mailing list.

That said, I don't think Change-Id (or Uuid or whatever the cookie tag
is named) needs to be committed to git. If people stuck their
Change-Id tag below '---' in their mail, it would solve the issue of
finding old revisions on the list. This would also allow tooling (like
patchwork) to track across revisions. It's pretty easy to work
backwards from a commit to _any_ one revision of the patch on the m-l,
and that will give you the Change-Id.

If Change-Id becomes widely useful below '---', you could add support
in patchwork to allow direct linking by Change-Id. This would allow
people to add Link: <patchwork-server/change-id/<change-id> to their
commit messages without first uploading it somewhere.

Sean

>
> Linus
> _______________________________________________
> Ksummit-discuss mailing list
> Ksummit-discuss@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss