Re: [Ksummit-discuss] Allowing something Change-Id (or something like it) in kernel commits

Christian Brauner
2019-08-23T20:02:30Z

[-- Attachment #1: Type: text/plain, Size: 2560 bytes --]

On Fri, Aug 23, 2019, 21:17 Thomas Gleixner <tglx@linutronix.de> wrote:

> On Fri, 23 Aug 2019, Dmitry Torokhov wrote:
> > On Fri, Aug 23, 2019 at 12:35:03PM -0400, Joel Fernandes wrote:
> > > On Fri, Aug 23, 2019 at 12:19 PM Dmitry Torokhov
> > > <dmitry.torokhov@gmail.com> wrote:
> > > > On Fri, Aug 23, 2019 at 05:48:55PM +0200, Thomas Gleixner wrote:
> > > > >
> > > > > Yes, it's work for the submitter, but it's always work if the
> submitter
> > > > > wants to have a proper trace.
> > > >
> > > > Here is where I disagree with you. As a patch submitter, I frankly
> could
> > > > not care less about proper trace, history, etc. I might be putting
> cover
> > >
> > > But that is exactly what the problem statement is. Doug does care
> > > about tracing/history and wants that to be more robust etc.
> >
> > Doug here is not a submitter ;)
>
> Well, if he wants the changeids there then submitters need to insert them,
> right? So it's work no matter what unless it can be automated with tooling.
>
> Guess what, how I inject the Link to the coverletter of the previous
> version of a patch series? Definitely not manualy.
>
> So yes, if you want proper traceability then all involved people have to do
> something. If it can be done with tooling fully automated, fine. If not,
> it's work whatever method you chose.
>
> We cannot enforce the changeid thing in the community, but Google can
> inforce it internally. So we give them a way to be traceable w/o plastering
> the kernel logs with potentially useless information.
>
> That said, I'm fine with a Link as well, as long as it is public
>

A link is definitely more helpful then the change-id.
Quite a few maintainers are already making use of links to various sites
anyway so I don't see a good reason not allow Links to Gerrit or whatever.

accessible. If not, then the coverletter/discard area is the place to use.
>

Right, change-id should go after --- which is also what Dmitry Vyukov
suggested.

One thing I wonder though. What's the ultimate goal here?
Enabling people to review on Gerrit and lkml simultaneously?
I mean, apart from tracking versions of patch series/patches this can't be
all, right?
We can already do that right now and I'm already doing that when applying
stuff to my tree: inserting the link to the version of the patch set I
applied and linking to the previous version in each new version of the
patchset.
That could also be automated.
So is allowing reviews both on Gerrit or whatever the goal here and if so
how do we ensure that lkml sees all reviews?

Christian

[-- Attachment #2: Type: text/html, Size: 3651 bytes --]