Re: [MAINTAINERS SUMMIT] [4/4] Discuss how to better prevent backports of commits that turn out to cause regressions

Steven Rostedt
2024-06-16T03:28:07Z

On Sat, 15 Jun 2024 18:13:57 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Fri, 14 Jun 2024 at 07:29, Michael Ellerman <mpe@ellerman.id.au> wrote:
> >
> > Message-Id: sucks, I want a link I can open with a single click.
>
> !00% agreed.
>
> There is no way in hell I will endorse adding more of those completely
> *idiotic* "Message-ID" things.
>
> Yes, people use them. It's a damn shame.
>
> There is no excuse for that completely broken model. It's objectively
> and unquestionably worse than having a "link".
>
> Here's the thing: if that message-ID isn't public, then that line
> SHOULD NOT EXIST and is an actual real problem. I personally look at
> those, and go "is that actually available on lore?"
>
> And if that message-id _is_ public, then it has a link, and it's much
> easier for people to check.
>
> Ergo: there is absolutely zero reason to ever use Message-ID.
>
> People need to stop advocating that sh*t.
>

After trying it for a brief period, I quickly came to the same conclusion.
I didn't like it because right after implementing it, I needed to get back
to the conversation and found I could no longer simply click on a link, and
I abandoned the "Message-Id" idea.

But I really like having a link to the patch I pulled, even if there was no
conversation about it. I use it for finding previous versions and so on,
which is useful for me.

Now, one day you looked at one of my "Link:" tags and was disappointed that
it didn't have a discussion behind it. I would like to differentiate links
that have a discussion with those that just are "I pulled it from here". I
don't like that I use "Link:" for both.

I prefer that "Link:" goes back to a discussion, but I would like a
separate tag for where the patch came from. What would you suggest?

1) Just keep using Links, and we can figure it out when we click on it.

2) Giving it a separate name:

a) "Pulled-from:"
b) "Submission:"
c) Something else

?

-- Steve