Re: [MAINTAINERS SUMMIT] [4/4] Discuss how to better prevent backports of commits that turn out to cause regressions

Geert Uytterhoeven
2024-06-14T15:08:55Z

Hi Konstantin,

On Fri, Jun 14, 2024 at 4:38 PM Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
> On Sat, Jun 15, 2024 at 12:29:09AM GMT, Michael Ellerman wrote:
> > > 1. disambiguates Link: trailers so they point to relevant online discussions
> > > 2. allows tooling like b4, patchwork, etc, to reliably match commits to
> > > submissions for the purposes of better code review automation
> > > 3. allows stable and similar projects to better track series grouping for
> > > commits
> >
> > Message-Id: sucks, I want a link I can open with a single click.
>
> But why would you want to, on a regular basis? Viewing the series submission
> has got to provide near zero useful info -- if it was accepted into the tree,
> then at most it would have a couple of stray code review trailers.

I open these links regularly (as in daily), for various reasons:
- Finding the thread to reply to when reporting a bug,
- Checking for new Rb-tags given,
- As a starting point for reading earlier submissions of the
same patch,
- ...

Lots of tools (gnome-terminal, mate-terminal, gitk, cgit, ...) support
opening URLs in commit logs at the blink of an eye. Having just a
Message-Id means more work (yes, I have lore configured as a search
engine in my browser).

That's also why I detest people putting patchwork URLs instead of
lore URLs in the Link:-tag: finding the thread in lore requires one
more click on "mailing list archive" (for patchwork.kernel.org)
or a copy-'n-paste of the Message-Id (for oh-the-horror
patchwork.freedesktop.org; and what if freedesktop.org goes away?)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds