Re: [MAINTAINERS/KERNEL SUMMIT] Trust and maintenance of file systems

Segher Boessenkool
2023-09-07T11:39:28Z

On Thu, Sep 07, 2023 at 12:48:25PM +0300, Dan Carpenter via Gcc-patches wrote:
> I started to hunt
> down all the Makefile which add a -Werror but there are a lot and
> eventually I got bored and gave up.

I have a patch stack for that, since 2014 or so. I build Linux with
unreleased GCC versions all the time, so pretty much any new warning is
fatal if you unwisely use -Werror.

> Someone should patch GCC so there it checks an environment variable to
> ignore -Werror. Somethine like this?

No. You should patch your program, instead. One easy way is to add a
-Wno-error at the end of your command lines. Or even just -w if you
want or need a bigger hammer.

Or nicer, put it all in Kconfig, like powerpc already has for example.
There is a CONFIG_WERROR as well, so maybe use that in all places?

> +static bool
> +ignore_w_error(void)
> +{
> + char *str;
> +
> + str = getenv("IGNORE_WERROR");
> + if (str && strcmp(str, "1") == 0)

space before (

> case OPT_Werror:
> + if (ignore_w_error())
> + break;
> dc->warning_as_error_requested = value;
> break;
>
> case OPT_Werror_:
> - if (lang_mask == CL_DRIVER)
> + if (ignore_w_error())
> + break;
> + if (lang_mask == CL_DRIVER)
> break;

The new indentation is messed up. And please don't move the existing
early-out to later, it make more sense earlier, the way it was.

Segher