Re: [MAINTAINERS SUMMIT] [4/4] Discuss how to better prevent backports of commits that turn out to cause regressions

Linus Torvalds
2024-06-16T16:40:26Z

On Sun, 16 Jun 2024 at 01:10, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> These days, it's mostly just that I have set am.message-id to true years
> ago; but since lore is managed by kernel.org, we can expect the URLs to
> be stable and the original reason to use Message-ID is obsolete. Having
> learnt right now about the applypatch-msg git hook, I've stuck a
>
> sed -i -e 's,^Message-ID: <\(.*\)>$,Link: https://lore.kernel.org/r/\1,'
> "$1"
>
> in there which should do the trick. I guess Michael and Takashi can do
> the same. :)

Please don't. At least not unless you are *SURE* that you only pick up
those messages from lore.

IOW, where did that original brain-dead Message-ID tag originate from?
Because if you use "git am", then using "-l" already does the right
thing.

So the actual fix is to *NOT* use "git am -i", but "git am -l".

Do not fix up the mess after the fact, particularly with a script that
can actually corrupt things and make up links that don't exist.

Just fix the mess at the source.

Linus