Re: How to fix problems with the sashiko review model

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Wed, Jul 22, 2026 at 11:10:45AM -0400, James Bottomley wrote:
> On Wed, 2026-07-22 at 06:43 -0700, Guenter Roeck wrote:
> [...]
> > For Sashiko, fork and clone
> > https://github.com/sashiko-dev/sashiko.git,
> > submit your changes into the clone, and send a pull request. Or at
> > least that is how I do it.

> > In the Sashiko source, per-subsystem prompts are located in directory
> > third_party/prompts/kernel/subsystem.

> OK, now I'm confused.  I thought

> https://github.com/masoncl/review-prompts

> was the source of truth for this, but that project seems to have been
> copied into sashiko rather than pulled in as a module.  If you want to
> improve the review prompts do you now have to submit to both (which is
> getting to be a bit wasteful)?

My experience is you submit to Chris's and it eventually gets pulled
into Roman's:

June 12
prompts: sync recent changes from review-prompts
https://github.com/sashiko-dev/sashiko/commit/07223d03b2657d809156b46c0b980725184f81e8

But from what I saw while searching for the above commit there are
updates to prompts in sashiko, not going first thru review-prompts.

- Arnaldo