Re: Patch pre-submission to Sashiko

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

On Tue, Oct 20, 2026 at 02:43:27PM -0600, Shuah Khan wrote:
> On 10/20/26 13:21, Theodore Tso wrote:

> > and maybe even:

> >     * Add a kunit test covering any changes made by the agentically
> >       generated code.

> kunit or kselftest covering any changes made by the agentically
> generated code

TBH having seen some LLM patches that come with LLM generated testcases
the testcases are much worse than the patches themselves.  Open coding,
weird structures, asserting bizzare things without explanation - just
generally really hard to understand what the test is trying to
accomplish and why.  Sometimes for a one and done test, especially one
you're not going to keep around, it doesn't matter so much but stuff
like that can really impact the maintainability of the testuite.  Some
of this is probably submitters paying comparatively less attention to
the tests and just throwing anything over the wall without review.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]