From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amit Shah <amit.shah@redhat.com>
Date: Mon, 10 Nov 2008 05:59:01 +0000
Subject: Re: [PATCH] KVM: Userspace: Make device-assignment work for kvm/ia64.
Message-Id: <200811101117.02029.amit.shah@redhat.com>
List-Id: <kvm-ia64.vger.kernel.org>
References: <706158FABBBA044BAD4FE898A02E4BC21983F921@pdsmsx503.ccr.corp.intel.com>
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC21983F921@pdsmsx503.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kvm-ia64@vger.kernel.org

* On Friday 07 Nov 2008 15:55:18 Zhang, Xiantao wrote:

> --- a/qemu/vl.c
> +++ b/qemu/vl.c
> @@ -8694,7 +8694,7 @@ static void help(int exitcode)
>  #endif
>  	   "-no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC\n"
>  	   "-no-kvm-pit	    disable KVM kernel mode PIT\n"
> -#if defined(TARGET_I386) || defined(TARGET_X86_64) || defined(__linux__)
> +#if defined(TARGET_I386) || defined(TARGET_X86_64) || defined(TARGET_IA64)
> || defined(__linux__) "-pcidevice

It would be better to use #if defined (USE_KVM_DEVICE_ASSIGNMENT) here (and in 
the rest of the file) instead of adding architectures to this list as is done 
in the Makefile.

Amit