From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Date: Wed, 25 Jun 2008 11:53:20 +0000
Subject: Re: [PATCH] irq assignment
Message-Id: <486231B0.9080904@qumranet.com>
List-Id: <kvm-ia64.vger.kernel.org>
References: <51CFAB8CB6883745AE7B93B3E084EBE201D2C53B@pdsmsx412.ccr.corp.intel.com>
In-Reply-To: <51CFAB8CB6883745AE7B93B3E084EBE201D2C53B@pdsmsx412.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kvm-ia64@vger.kernel.org

(copying qemu-devel)

Xu, Anthony wrote:
> Subject: [PATCH] Irq assignment
>
> 1. use bimodal _PRT
> 2. pci device can use irq > 15, reduce interrupt sharing
> 3. test by running linux guest in kvm-ia64, kvm-i32(w/ wo/ -no-kvm)
>
>   


> +
> +static int ioapic_irq_count[IOAPIC_NUM_PINS];
> +
>  void ioapic_set_irq(void *opaque, int vector, int level)
>  {
>      IOAPICState *s = opaque;
> -
> +    if( vector >= 16 ){
> +         if( level )
> +             ioapic_irq_count[vector] += 1;
> +         else
> +             ioapic_irq_count[vector] -= 1;
> +         level = (ioapic_irq_count[vector] != 0);
> +    }
> +#ifdef KVM_CAP_IRQCHIP
> +    if (kvm_enabled())
> +	if (kvm_set_irq(vector, ioapic_irq_count[vector] = 0))
> +	    return;
> +#endif
>  

It's legal to call ioapic_set_irq(vector, 1) twice, which will screw up 
the level calculation.

We need qemu_irq_or(), similar to qemu_irq_invert():

    qemu_irq qemu_irq_or(qemu_irq irqs[], int nr);


Also, this is not the place for doing the or.  The ioapic does not know 
which interrupts are level connected and which are not.  This belongs on 
the pci level (or the mainboard level).

-- 
error compiling committee.c: too many arguments to function