From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Date: Wed, 24 Sep 2008 15:33:34 +0000
Subject: Re: [patch] do not allocate code_gen buffer on ia64
Message-Id: <48DA5DCE.4020707@codemonkey.ws>
List-Id: <kvm-ia64.vger.kernel.org>
References: <48DA2465.1040709@sgi.com>
In-Reply-To: <48DA2465.1040709@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kvm-ia64@vger.kernel.org

Avi Kivity wrote:
> Jes Sorensen wrote:
>> Avi Kivity wrote:
>>> Jes Sorensen wrote:
>>>> Hi,
>>>>
>>>> This one limits the code_gen_buffer_size on ia64, phys_mem_size/4
>>>> really gets out of hand when you boot say a 64GB guest.
>>>
>>> ia64 doesn't codegen; why not set it to zero?
>>
>> How about this one then?
>>
>
> Applied, thanks.  Note qemu uses 4 spaces for intedenation.  Talk to 
> your editor.

It would seem better to replace #ifdef TARGET_IA64 with if (kvm_enabled()).

If QEMU ever got proper ia64 target support, that's going to be an ugly 
bug to find.

Regards,

Anthony Liguori