From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Thu, 02 Oct 2008 13:04:16 +0000 Subject: Re: [PATCH 4/8]kvm: Split arch/x86/kvm/irq.c to two parts. Message-Id: <48E4C6D0.5080703@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Zhang, Xiantao wrote: > From bb0c01b997d16ff1c1b9b0e797a581577c385b54 Mon Sep 17 00:00:00 2001 > From: Xiantao Zhang > Date: Mon, 29 Sep 2008 10:59:30 +0800 > Subject: [PATCH] kvm: Split arch/x86/kvm/irq.c to two parts. > > Moving irq ack notification logic as common, and make > it shared with ia64 side. > > 8 files changed, 14 insertions(+), 48 deletions(-) > Warning sign - more deletions than insertions. > __kvm_migrate_pit_timer(vcpu); > } > - > -/* This should be called with the kvm->lock mutex held */ > -void kvm_set_irq(struct kvm *kvm, int irq, int level) > -{ > - /* Not possible to detect if the guest uses the PIC or the > - * IOAPIC. So set the bit in both. The guest will ignore > - * writes to the unused one. > - */ > - kvm_ioapic_set_irq(kvm->arch.vioapic, irq, level); > - kvm_pic_set_irq(pic_irqchip(kvm), irq, level); > -} > - > -void kvm_notify_acked_irq(struct kvm *kvm, unsigned gsi) > -{ > - struct kvm_irq_ack_notifier *kian; > - struct hlist_node *n; > - > - hlist_for_each_entry(kian, n, &kvm->arch.irq_ack_notifier_list, > link) > - if (kian->gsi = gsi) > - kian->irq_acked(kian); > -} > - > -void kvm_register_irq_ack_notifier(struct kvm *kvm, > - struct kvm_irq_ack_notifier *kian) > -{ > - hlist_add_head(&kian->link, &kvm->arch.irq_ack_notifier_list); > -} > - > -void kvm_unregister_irq_ack_notifier(struct kvm *kvm, > - struct kvm_irq_ack_notifier *kian) > -{ > - hlist_del(&kian->link); > -} > Where did these go? -- error compiling committee.c: too many arguments to function