From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu
Date: Wed, 22 Oct 2008 10:47:08 +0000 [thread overview]
Message-ID: <48FF04AC.7060406@redhat.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01B489F8@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> Before Aps going to block status, it should make sure SIGINT is
> masked, otherwise, it may eat SIGINT from user killing the guest, and
> results in Qemu hanging there, becasue main thread can't get it to free
> guest's resource.
>
>
> diff --git a/arch/ia64/kvm/kvm-ia64.c b/arch/ia64/kvm/kvm-ia64.c
> index a40223f..9929c6f 100644
> --- a/arch/ia64/kvm/kvm-ia64.c
> +++ b/arch/ia64/kvm/kvm-ia64.c
> @@ -439,7 +439,6 @@ int kvm_emulate_halt(struct kvm_vcpu *vcpu)
> expires = div64_u64(itc_diff, cyc_per_usec);
> kt = ktime_set(0, 1000 * expires);
>
> - down_read(&vcpu->kvm->slots_lock);
> vcpu->arch.ht_active = 1;
> hrtimer_start(p_ht, kt, HRTIMER_MODE_ABS);
>
> @@ -452,7 +451,6 @@ int kvm_emulate_halt(struct kvm_vcpu *vcpu)
> if (vcpu->arch.mp_state = KVM_MP_STATE_HALTED)
> vcpu->arch.mp_state > KVM_MP_STATE_RUNNABLE;
> - up_read(&vcpu->kvm->slots_lock);
>
> if (vcpu->arch.mp_state != KVM_MP_STATE_RUNNABLE)
> return -EINTR;
>
These bits appear unrelated?
The rest of the patch is fine.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-10-22 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 5:58 [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu 0) Zhang, Xiantao
2008-10-20 7:23 ` [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu Avi Kivity
2008-10-20 8:08 ` [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu 0) Zhang, Xiantao
2008-10-20 8:43 ` [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu Avi Kivity
2008-10-20 9:03 ` [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu 0) Zhang, Xiantao
2008-10-22 3:13 ` Zhang, Xiantao
2008-10-22 10:47 ` Avi Kivity [this message]
2008-10-23 2:00 ` [PATCH] kvm/ia64: Ensure SIGINT delivered to main thread (vcpu Zhang, Xiantao
2008-10-23 4:31 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF04AC.7060406@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox