From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Tue, 04 Nov 2008 14:47:24 +0000 Subject: Re: [patch] remove vcpu_info array v5 Message-Id: <4910607C.7040405@redhat.com> List-Id: References: <4909C00F.8050704@sgi.com> In-Reply-To: <4909C00F.8050704@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Glauber Costa wrote: >>> Yes, but I believe the whole point of jes patches is to remove those >>> limits. >>> >>> >> So we could linear search huge lists? Or code hashes where arrays would do? >> No, sir. >> >> An array of pointers statically sized at MAX_CPUS is fine. If you insist, >> you can realloc() it on demand. >> > > Yes, I agree. having MAX_CPUS is fine, and if we need to, we can increase that. > but again: then the direction of the flow is better be have qemu to > use a env array, > and then we can use the same method for kvm. > I only object to the linear search; not to the folding of vcpu_info into CPUState. -- error compiling committee.c: too many arguments to function