From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Tue, 11 Nov 2008 09:26:56 +0000 Subject: Re: [patch] remove vcpu_info array v5 Message-Id: <49194FE0.4030003@redhat.com> List-Id: References: <4909C00F.8050704@sgi.com> In-Reply-To: <4909C00F.8050704@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Jes Sorensen wrote: > Avi Kivity wrote: >> The code I mentioned only runs if the -no-kvm-irqchip option is >> passed. It's not the highest performing option... > > What I meant was that I was able to compile the code, and there was only > one piece left that needed that function, which is why I moved it and > made it static in the acpi code. > That's because there is another static array in acpi.c... >> So this isn't used a lot. But cpus definitely use cpu numbers (as >> apic ids), so qemu needs to be prepared to handle this. As to >> scalability, that takes will take a lot more work than >> removing/changing arbitrary limits. Look at qemu_mutex and weep. > > Well we have to start somewhere. Just because there's limits in other > areas too, doesn't mean we should discard valid improvements elsewhere. > I'll get to some of that at some point, but there's soo many cards used > to build this house.... Your patch builds the 16383rd floor while ignoring the 15th. Qemu scaling issues are much, much more painful than what you were addressing. -- error compiling committee.c: too many arguments to function