kvm-ia64.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [patch] pass opague CPUState through libkvm instead of int vcpu
Date: Tue, 18 Nov 2008 12:55:02 +0000	[thread overview]
Message-ID: <4922BB26.4020308@redhat.com> (raw)
In-Reply-To: <491C59DD.6070005@sgi.com>

Jes Sorensen wrote:
> I pulled out the part of the patch that does the opague 'env' pointer.
> It should be pretty straight forward - the vcpu_info patch will go on
> top of this, but I'll work on that tomorrow.
>
> Let me know what you think - this is about as small I can make this
> patch :-)

It's good; applied, thanks.

There's a slight redundancy in that some callbacks are passed two 
opaques (per-cpu and per-vm), but it won't kill anyone.

(btw, this could have been done much more simply: declare a thread local 
variable to hold the current env)

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2008-11-18 12:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 16:46 [patch] pass opague CPUState through libkvm instead of int vcpu Jes Sorensen
2008-11-18 12:55 ` Avi Kivity [this message]
2008-11-18 12:59 ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4922BB26.4020308@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).