[patch] ia64 restore irq state before calling kvm_vcpu_init

[patch] ia64 restore irq state before calling kvm_vcpu_init

[Jes Sorensen]

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]

Hi,

Another one to avoid calling kmalloc() with local interrupts enabled
on ia64.

Cheers,
Jes


[-- Attachment #2: 0004-kvm-ia64-irq-sleep.patch --]
[-- Type: text/x-patch, Size: 918 bytes --]

Make sure to restore the psr after calling kvm_insert_vmm_mapping()
which calls ia64_itr_entry() as it disables local interrupts and
kvm_vcpu_init() may sleep.

Avoids a warning from the lock debugging code.

Signed-off-by: Jes Sorensen <jes@sgi.com>

---
 arch/ia64/kvm/kvm-ia64.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6.git/arch/ia64/kvm/kvm-ia64.c
===================================================================
--- linux-2.6.git.orig/arch/ia64/kvm/kvm-ia64.c
+++ linux-2.6.git/arch/ia64/kvm/kvm-ia64.c
@@ -1235,6 +1235,7 @@
 
 	local_irq_save(psr);
 	r = kvm_insert_vmm_mapping(vcpu);
+	local_irq_restore(psr);
 	if (r)
 		goto fail;
 	r = kvm_vcpu_init(vcpu, vcpu->kvm, id);
@@ -1252,13 +1253,11 @@
 		goto uninit;
 
 	kvm_purge_vmm_mapping(vcpu);
-	local_irq_restore(psr);
 
 	return 0;
 uninit:
 	kvm_vcpu_uninit(vcpu);
 fail:
-	local_irq_restore(psr);
 	return r;
 }
 

[patch] ia64 restore irq state before calling kvm_vcpu_init

[Jes Sorensen]

[-- Attachment #1: Type: text/plain, Size: 98 bytes --]

Hi,

Another one to avoid calling kmalloc() with local interrupts enabled
on ia64.

Cheers,
Jes



[-- Attachment #2: 0004-kvm-ia64-irq-sleep.patch --]
[-- Type: text/x-patch, Size: 919 bytes --]

Make sure to restore the psr after calling kvm_insert_vmm_mapping()
which calls ia64_itr_entry() as it disables local interrupts and
kvm_vcpu_init() may sleep.

Avoids a warning from the lock debugging code.

Signed-off-by: Jes Sorensen <jes@sgi.com>

---
 arch/ia64/kvm/kvm-ia64.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6.git/arch/ia64/kvm/kvm-ia64.c
===================================================================
--- linux-2.6.git.orig/arch/ia64/kvm/kvm-ia64.c
+++ linux-2.6.git/arch/ia64/kvm/kvm-ia64.c
@@ -1235,6 +1235,7 @@
 
 	local_irq_save(psr);
 	r = kvm_insert_vmm_mapping(vcpu);
+	local_irq_restore(psr);
 	if (r)
 		goto fail;
 	r = kvm_vcpu_init(vcpu, vcpu->kvm, id);
@@ -1252,13 +1253,11 @@
 		goto uninit;
 
 	kvm_purge_vmm_mapping(vcpu);
-	local_irq_restore(psr);
 
 	return 0;
 uninit:
 	kvm_vcpu_uninit(vcpu);
 fail:
-	local_irq_restore(psr);
 	return r;
 }
 

RE: [patch] ia64 restore irq state before calling kvm_vcpu_init

[Zhang, Xiantao]

Acked-by : Xiantao Zhang <xiantao.zhang@intel.com> 

-----Original Message-----
From: kvm-ia64-owner@vger.kernel.org [mailto:kvm-ia64-owner@vger.kernel.org] On Behalf Of Jes Sorensen
Sent: Thursday, April 16, 2009 10:08 PM
To: Avi Kivity
Cc: Zhang, Xiantao; kvm-ia64@vger.kernel.org
Subject: [patch] ia64 restore irq state before calling kvm_vcpu_init

Hi,

Another one to avoid calling kmalloc() with local interrupts enabled
on ia64.

Cheers,
Jes

Re: [patch] ia64 restore irq state before calling kvm_vcpu_init

[Avi Kivity]

Jes Sorensen wrote:
> Hi,
>
> Another one to avoid calling kmalloc() with local interrupts enabled
> on ia64.
>

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function