[patch] ia64 vcpu_reset() do not call kmalloc() with irqs disabled

[patch] ia64 vcpu_reset() do not call kmalloc() with irqs disabled

[Jes Sorensen]

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Hi,

Here we go again, another case where we were calling kmalloc() through
vcpu_reset() while local interrupts were disabled.

Cheers,
Jes


[-- Attachment #2: 0006-kvm-ia64-vcpu-reset-sleep.patch --]
[-- Type: text/x-patch, Size: 695 bytes --]

Restore local irq enabled state before calling kvm_arch_vcpu_init(),
which calls kmalloc(GFP_KERNEL).

Signed-off-by: Jes Sorensen <jes@sgi.com>

---
 arch/ia64/kvm/kvm-ia64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.git/arch/ia64/kvm/kvm-ia64.c
===================================================================
--- linux-2.6.git.orig/arch/ia64/kvm/kvm-ia64.c
+++ linux-2.6.git/arch/ia64/kvm/kvm-ia64.c
@@ -1919,6 +1919,7 @@
 	long psr;
 	local_irq_save(psr);
 	r = kvm_insert_vmm_mapping(vcpu);
+	local_irq_restore(psr);
 	if (r)
 		goto fail;
 
@@ -1931,7 +1932,6 @@
 	kvm_purge_vmm_mapping(vcpu);
 	r = 0;
 fail:
-	local_irq_restore(psr);
 	return r;
 }
 

RE: [patch] ia64 vcpu_reset() do not call kmalloc() with irqs

[Zhang, Xiantao]

Thanks, Jes!

Acked-by: Xiantao Zhang <xiantao.zhang@intel.com>

Jes Sorensen wrote:
> Hi,
> 
> Here we go again, another case where we were calling kmalloc() through
> vcpu_reset() while local interrupts were disabled.
> 
> Cheers,
> Jes

Re: [patch] ia64 vcpu_reset() do not call kmalloc() with irqs disabled

[Avi Kivity]

Jes Sorensen wrote:
> Hi,
>
> Here we go again, another case where we were calling kmalloc() through
> vcpu_reset() while local interrupts were disabled.

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function