[patch] kvm.h only needs asm/types.h

[patch] kvm.h only needs asm/types.h

[Jes Sorensen]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

Hi,

I'd like to push this one upstream - it allows us to share asm/kvm.h
directly with QEMU, without having to modify it.

Patch against latest Linus tree.

Cheers,
Jes


[-- Attachment #2: 1000-kvm-ia64-asm-types.h --]
[-- Type: text/x-chdr, Size: 632 bytes --]

We only need asm/types.h in asm/kvm.h on ia64. This allows this file
to be shared with KVM userland without modifications.

Signed-off-by: Jes Sorensen <jes@sgi.com>

---
 arch/ia64/include/asm/kvm.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.git/arch/ia64/include/asm/kvm.h
===================================================================
--- linux-2.6.git.orig/arch/ia64/include/asm/kvm.h
+++ linux-2.6.git/arch/ia64/include/asm/kvm.h
@@ -21,7 +21,7 @@
  *
  */
 
-#include <linux/types.h>
+#include <asm/types.h>
 #include <linux/ioctl.h>
 
 /* Select x86 specific features in <linux/kvm.h> */

RE: [patch] kvm.h only needs asm/types.h

[Zhang, Xiantao]

Generally we should include linux/types.h instead of asm/types.h for kernel.  We have already used the magic hack-module.awk(replace linux/types.h with asm/types.h) to make it work in userspace.  :) 
Xiantao

Jes Sorensen wrote:
> Hi,
> 
> I'd like to push this one upstream - it allows us to share asm/kvm.h
> directly with QEMU, without having to modify it.
> 
> Patch against latest Linus tree.
> 
> Cheers,
> Jes

Re: [patch] kvm.h only needs asm/types.h

[Jes Sorensen]

Zhang, Xiantao wrote:
> Generally we should include linux/types.h instead of asm/types.h for kernel.  We have already used the magic hack-module.awk(replace linux/types.h with asm/types.h) to make it work in userspace.  :) 
> Xiantao

Yes and no, in this case we don't need it, and there is no reason to
modify the kernel headers for KVM if we can share them unmodified.

Cheers,
Jes

RE: [patch] kvm.h only needs asm/types.h

[Zhang, Xiantao]

Jes Sorensen wrote:
> Zhang, Xiantao wrote:
>> Generally we should include linux/types.h instead of asm/types.h for
>> kernel.  We have already used the magic hack-module.awk(replace
>> linux/types.h with asm/types.h) to make it work in userspace.  :)
>> Xiantao  
> 
> Yes and no, in this case we don't need it, and there is no reason to
> modify the kernel headers for KVM if we can share them unmodified.

When you do "make sync" in userland,  many files are modifed except this one. :)
Xiantao

Re: [patch] kvm.h only needs asm/types.h

[Jes Sorensen]

Zhang, Xiantao wrote:
> Jes Sorensen wrote:
>> Zhang, Xiantao wrote:
>>> Generally we should include linux/types.h instead of asm/types.h for
>>> kernel.  We have already used the magic hack-module.awk(replace
>>> linux/types.h with asm/types.h) to make it work in userspace.  :)
>>> Xiantao  
>> Yes and no, in this case we don't need it, and there is no reason to
>> modify the kernel headers for KVM if we can share them unmodified.
> 
> When you do "make sync" in userland,  many files are modifed except this one. :)
> Xiantao

I thought make sync had been removed :-) It at least no longer works.

Cheers,
Jes

RE: [patch] kvm.h only needs asm/types.h

[Zhang, Xiantao]

Jes Sorensen wrote:
> Zhang, Xiantao wrote:
>> Jes Sorensen wrote:
>>> Zhang, Xiantao wrote:
>>>> Generally we should include linux/types.h instead of asm/types.h
>>>> for kernel.  We have already used the magic hack-module.awk(replace
>>>> linux/types.h with asm/types.h) to make it work in userspace.  :)
>>>> Xiantao
>>> Yes and no, in this case we don't need it, and there is no reason to
>>> modify the kernel headers for KVM if we can share them unmodified.
>> 
>> When you do "make sync" in userland,  many files are modifed except
>> this one. :) Xiantao
> 
> I thought make sync had been removed :-) It at least no longer works.

If make sync won't exist in future, you may only need to submit a patch for qemu-kvm.git to fix the header file directly, :-)

Even with the patch you proposed, we still can't make kernel and userspace share all header files. For example, the header files under include/linux should be hacked also.  
Xiantao 

Re: [patch] kvm.h only needs asm/types.h

[Jes Sorensen]

Zhang, Xiantao wrote:
> Jes Sorensen wrote:
>> I thought make sync had been removed :-) It at least no longer works.
> 
> If make sync won't exist in future, you may only need to submit a patch for qemu-kvm.git to fix the header file directly, :-)
> 
> Even with the patch you proposed, we still can't make kernel and userspace share all header files. For example, the header files under include/linux should be hacked also.  
> Xiantao 

Yes I understand that, I am just trying to make things easier where
possible, thats all.

Cheers,
Jes