From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Mon, 04 May 2009 09:01:22 +0000 Subject: Re: [PATCH 02/04] qemu-kvm: Add header files for ia64. Message-Id: <49FEAEE2.7040305@redhat.com> List-Id: References: <706158FABBBA044BAD4FE898A02E4BC236A2BC05@pdsmsx503.ccr.corp.intel.com> In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC236A2BC05@pdsmsx503.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Jes Sorensen wrote: > Zhang, Xiantao wrote: >> Hi, Jes >> There should be no issue here. You may refer to >> qemu-kvm/kvm/kernel/arch/x86/include/asm/kvm.h, and it also includes >> this stuff. I remebered this stuff was used to solve the issues when >> uses kernel header files in userspace and the author should be Avi:-) >> You know, kernel header may include CONFIG_$ARCH macros but they are >> meaningless in userspace, so needs a way to solve the gap. But anyway >> we can do some cleanup or introduce new ways to solve the issue. Xiantao > > Hi Xiantao, > > I noticed it's in the x86 code as well - but I still think it's silly to > add to the ia64 tree when we don't need it. > > Of course, Avi should fix up his headers too :-) > It's autogenerated; but we do need a cleaner solution. qemu upstream is working on a more inclusive Linux header takeover; we can use that when it's done. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.