From: Jes Sorensen <jes@sgi.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [patch] fix qemu-kvm to build when gdbstub is disabled
Date: Thu, 07 May 2009 08:14:09 +0000 [thread overview]
Message-ID: <4A029851.3030503@sgi.com> (raw)
In-Reply-To: <4A01AFE8.3020008@sgi.com>
Zhang, Xiantao wrote:
> --- qemu-kvm.orig/vl.c
> +++ qemu-kvm/vl.c
> @@ -4417,13 +4417,11 @@
> }
> if (cpu_can_run(env))
> ret = qemu_cpu_exec(env);
> -#ifndef CONFIG_GDBSTUB
> ^^^^^^^^^^^
> Don't know why change #ifdef to #ifndef in upstream, and I remember it should be ifdef before. I believe this stuff should be compiled only if CONFIG_GDBSTUB is defined.
Yes, I made get_set_top_cpu() a noop instead when compiled with
CONFIG_GDBSTUB disabled, that way we avoid a bunch of these silly
#ifdefs.
Cheers,
Jes
next prev parent reply other threads:[~2009-05-07 8:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 15:42 [patch] fix qemu-kvm to build when gdbstub is disabled Jes Sorensen
2009-05-07 1:24 ` Zhang, Xiantao
2009-05-07 8:14 ` Jes Sorensen [this message]
2009-05-07 9:31 ` Avi Kivity
2009-05-07 9:50 ` Zhang, Xiantao
2009-05-07 9:59 ` Avi Kivity
2009-05-07 10:51 ` Jan Kiszka
2009-05-07 11:00 ` Avi Kivity
2009-05-07 11:13 ` Jan Kiszka
2009-05-07 11:28 ` Avi Kivity
2009-05-07 11:38 ` Jan Kiszka
2009-05-07 12:34 ` Jes Sorensen
2009-05-07 12:59 ` Jan Kiszka
2009-05-07 13:03 ` Jes Sorensen
2009-05-07 13:07 ` Jan Kiszka
2009-05-07 13:31 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A029851.3030503@sgi.com \
--to=jes@sgi.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox