From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Date: Thu, 07 May 2009 08:14:09 +0000 Subject: Re: [patch] fix qemu-kvm to build when gdbstub is disabled Message-Id: <4A029851.3030503@sgi.com> List-Id: References: <4A01AFE8.3020008@sgi.com> In-Reply-To: <4A01AFE8.3020008@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Zhang, Xiantao wrote: > --- qemu-kvm.orig/vl.c > +++ qemu-kvm/vl.c > @@ -4417,13 +4417,11 @@ > } > if (cpu_can_run(env)) > ret = qemu_cpu_exec(env); > -#ifndef CONFIG_GDBSTUB > ^^^^^^^^^^^ > Don't know why change #ifdef to #ifndef in upstream, and I remember it should be ifdef before. I believe this stuff should be compiled only if CONFIG_GDBSTUB is defined. Yes, I made get_set_top_cpu() a noop instead when compiled with CONFIG_GDBSTUB disabled, that way we avoid a bunch of these silly #ifdefs. Cheers, Jes