From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Thu, 07 May 2009 09:26:42 +0000 Subject: Re: [patch] fix - do not build blobs when blobs are not needed Message-Id: <4A02A952.60204@redhat.com> List-Id: References: <4A02A1BA.5020003@sgi.com> In-Reply-To: <4A02A1BA.5020003@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Jes Sorensen wrote: > Hi, > > Don't like ugly assembler errors because QEMU tries to build some x86 > assembly code which isn't needed on non-x86. .PHONY: kvm/extboot +ifdef INSTALL_BLOBS all: kvm/extboot kvm/extboot: @@ -427,3 +428,4 @@ || ! cmp -s pc-bios/extboot.bin $@/extboot.bin; then \ cp $@/extboot.bin pc-bios/extboot.bin; \ fi +endif Index: qemu-kvm/configure =================================--- qemu-kvm.orig/configure +++ qemu-kvm/configure @@ -356,6 +356,7 @@ cpu_emulation="no" gdbstub="no" slirp="no" + blobs="no" fi if [ "$cpu" = "powerpc" ]; then kvm="yes" Seems a bit heavy handed. blobs != extboot. How about instead: build-targets-x86 = kvm/extboot all: $(build-targets-$(ARCH)) (or something similar that builds) -- error compiling committee.c: too many arguments to function