From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Thu, 07 May 2009 11:28:49 +0000 Subject: Re: [patch] fix qemu-kvm to build when gdbstub is disabled Message-Id: <4A02C5F1.4060205@redhat.com> List-Id: References: <4A01AFE8.3020008@sgi.com> In-Reply-To: <4A01AFE8.3020008@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org Jan Kiszka wrote: >> I agree, unless >> >> - we want to make gdbstub support configurable (don't see any >> overwhelming reason for this, but maybe others do) >> - we want to merge ia64 kvm support upstream, and don't want to impose >> gdbstub support (though I'd recommend properly implementing gdbstub) >> >> In any case, I'm okay with dropping the check upstream and applying the >> local fixup. >> > > The last ia64 tcg patch I saw one or two days ago was missing gdb > support, too (and may suffer from some brokenness for that reason). I didn't see ia64/tcg. Did you mean s390? That was host only IIRC. > But > I would suggest for both cases (tcg and kvm) to temporarily provide > stubs/placeholders instead of keeping the central #ifdefs. > Agreed. -- error compiling committee.c: too many arguments to function