From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Date: Wed, 13 Jan 2010 09:22:39 +0000
Subject: Re: + kvm-ia64-dereference-of-null-pointer-in-set_pal_result.patch
Message-Id: <4B4D90DF.7020700@redhat.com>
List-Id: <kvm-ia64.vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kvm-ia64@vger.kernel.org

On 01/13/2010 12:11 AM, akpm@linux-foundation.org wrote:
> Subject: kvm/ia64: dereference of NULL pointer in set_pal_result()
> From: Roel Kluin<roel.kluin@gmail.com>
>
> Do not dereference a NULL pointer
>
> diff -puN arch/ia64/kvm/kvm_fw.c~kvm-ia64-dereference-of-null-pointer-in-set_pal_result arch/ia64/kvm/kvm_fw.c
> --- a/arch/ia64/kvm/kvm_fw.c~kvm-ia64-dereference-of-null-pointer-in-set_pal_result
> +++ a/arch/ia64/kvm/kvm_fw.c
> @@ -75,9 +75,11 @@ static void set_pal_result(struct kvm_vc
>   	struct exit_ctl_data *p;
>
>   	p = kvm_get_exit_data(vcpu);
> -	if (p&&  p->exit_reason = EXIT_REASON_PAL_CALL) {
> +	if (!p)
> +		return;
> +	if (p->exit_reason = EXIT_REASON_PAL_CALL) {
>   		p->u.pal_data.ret = result;
> -		return ;
> +		return;
>   	}
>   	INIT_PAL_STATUS_UNIMPLEMENTED(p->u.pal_data.ret);
>   }
>    


kvm_get_exit_data() cannot return a NULL pointer.

Where did this come from?

-- 
error compiling committee.c: too many arguments to function