From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Tue, 13 Apr 2010 07:05:38 +0000 Subject: Re: [PATCH] KVM: fix the handling of dirty bitmaps to avoid overflows Message-Id: <4BC417C2.9030905@redhat.com> List-Id: References: <20100412193535.6c502695.yoshikawa.takuya@oss.ntt.co.jp> In-Reply-To: <20100412193535.6c502695.yoshikawa.takuya@oss.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org On 04/13/2010 10:03 AM, Takuya Yoshikawa wrote: >> It's better to limit memory slots to something that can be handled by >> everything, then. 2^31 pages is plenty. Return -EINVAL if the slot is >> too large. > > > I agree with that, so we make this patch pending to fix like that? > -- or should make a new patch based on this patch? We need a new patch to block oversize memory slots. The current patch can come on top (but now page numbers fit inside an int, so it is just a cleanup, not a bugfix). -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.