From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Date: Fri, 23 Apr 2010 10:28:53 +0000
Subject: Re: [PATCH RFC v2 5/6] KVM: moving dirty bitmaps to user space
Message-Id: <4BD17665.5090101@redhat.com>
List-Id: <kvm-ia64.vger.kernel.org>
References: <20100420200225.efca602f.yoshikawa.takuya@oss.ntt.co.jp>
In-Reply-To: <20100420200225.efca602f.yoshikawa.takuya@oss.ntt.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kvm-ia64@vger.kernel.org

On 04/22/2010 12:07 PM, Takuya Yoshikawa wrote:
>
>>
>>> + slots->memslots[i].dirty_bitmap = NULL;
>>> + slots->memslots[i].dirty_bitmap_old = NULL;
>>> kvm_free_physmem_slot(&slots->memslots[i], NULL);
>>> + }
>>>
>>>
>>> +/*
>>> + * Please use generic *_user bitops once they become available.
>>> + * Be careful setting the bit won't be done atomically.
>>> + */
>>
>> Please introduce the user bitops as part of this patchset.
>>
>
> OK, I will do in the next version. In this RFC, I would be happy if I can
> know the overall design is right or not.
>

Everything looks reasonable to me.

Do you have performance numbers?  I'm interested in both measurements of 
KVM_SWITCH_DIRTY_LOG under various conditions and macro benchmarks (for 
example, total guest throughput improvement under Kemari).

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.