From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Fri, 23 Apr 2010 12:42:31 +0000 Subject: Re: [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Message-Id: <4BD195B7.3070409@redhat.com> List-Id: References: <20100420200353.2d2a6dec.yoshikawa.takuya@oss.ntt.co.jp> In-Reply-To: <20100420200353.2d2a6dec.yoshikawa.takuya@oss.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org On 04/23/2010 03:27 PM, Arnd Bergmann wrote: > >> Using a 64-bit integer avoids the problem (though perhaps not sufficient >> for s390, Arnd?) >> > When there is only a __u64 for the address, it will work on s390 as well, > gcc is smart enough to clear the upper bit on a cast from long to pointer. > Ah, much more convenient than compat_ioctl. I assume it part of the ABI, not a gccism? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.