From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Date: Wed, 12 May 2010 09:25:10 +0000 Subject: Re: [RFC][PATCH 7/12 not tested yet] PPC: introduce __set_bit() like Message-Id: <4BEA73F6.7020400@oss.ntt.co.jp> List-Id: References: <20100504220418.083929bc.takuya.yoshikawa@gmail.com> In-Reply-To: <20100504220418.083929bc.takuya.yoshikawa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org >> >> +static inline int set_bit_user_non_atomic(int nr, void __user *addr) >> +{ >> + u8 __user *p; >> + u8 val; >> + >> + p = (u8 __user *)((unsigned long)addr + nr / BITS_PER_BYTE); >> > > Does C do the + or the / first? Either way, I'd like to see brackets here :) OK, I'll change like that! I like brackets style too :) > > > Alex >