From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Thu, 24 Jun 2010 08:10:52 +0000 Subject: Re: [PATCH v2 3/4] KVM: cleanup: remove kvm_get_dirty_log() Message-Id: <4C23130C.8070206@redhat.com> List-Id: References: <20100623150134.9fb5915b.yoshikawa.takuya@oss.ntt.co.jp> In-Reply-To: <20100623150134.9fb5915b.yoshikawa.takuya@oss.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org On 06/24/2010 03:58 AM, Marcelo Tosatti wrote: > >> Well yes, I expect that not using rcu_dereference() (and >> srcu_read_lock()) is a bug here. >> >> Marcelo? >> > No because slots_lock is held which serializes with memslot updates. > Right, I need to reread Documentation/kvm/locking.txt. -- error compiling committee.c: too many arguments to function