From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Date: Tue, 09 Nov 2010 15:42:37 +0000 Subject: Re: [PATCH] KVM: Clean up vm creation and release Message-Id: <4CD96BED.5080504@de.ibm.com> List-Id: References: <4CD96195.2000708@siemens.com> In-Reply-To: <4CD96195.2000708@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index 985d825..d8d1877 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -164,24 +164,18 @@ long kvm_arch_vm_ioctl(struct file *filp, > return r; > } > > -struct kvm *kvm_arch_create_vm(void) > +int kvm_arch_create_vm(struct kvm *kvm) needs to be renamed to kvm_arch_init_vm [...] > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -441,7 +441,19 @@ int kvm_arch_vcpu_runnable(struct kvm_vcpu *vcpu); > > void kvm_free_physmem(struct kvm *kvm); > > -struct kvm *kvm_arch_create_vm(void); > +#ifndef __KVM_HAVE_ARCH_VM_ALLOC > +static inline struct kvm *kvm_arch_alloc_vm(void) > +{ > + return kzalloc(sizeof(struct kvm), GFP_KERNEL); I have not checked kvm.git but on Linux head we need #include for kzalloc. Christian