From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH 2/3] KVM: Centralize slots_lock aquisition during KVM_CREATE_IRQCHIP
Date: Thu, 16 Dec 2010 09:55:11 +0000 [thread overview]
Message-ID: <4D09E1FF.9040408@redhat.com> (raw)
In-Reply-To: <20101216014326.9210211a.takuya.yoshikawa@gmail.com>
On 12/16/2010 11:47 AM, Takuya Yoshikawa wrote:
>> They're under srcu now, the comments are outdated.
>>
>> We used to have slots_lock be a rwsem, taken for read or write as
>> necessary. Now we use srcu for read, and the slots_lock mutex +
>> synchronize_srcu for write.
>>
>
>
> Ah, would you mind updating the comments?
> - or just removing outdated ones?
>
>
Fixing the comments would be good.
> I will reread these locking based on your answer!
>
One day I'll write Documentation/kvm/locking.txt, so it could get
outdated as well.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-12-16 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 16:43 [PATCH 2/3] KVM: Centralize slots_lock aquisition during Takuya Yoshikawa
2010-12-16 9:11 ` [PATCH 2/3] KVM: Centralize slots_lock aquisition during KVM_CREATE_IRQCHIP Avi Kivity
2010-12-16 9:29 ` Takuya Yoshikawa
2010-12-16 9:34 ` Avi Kivity
2010-12-16 9:47 ` Takuya Yoshikawa
2010-12-16 9:55 ` Avi Kivity [this message]
2010-12-16 12:51 ` [PATCH 2/3] KVM: Centralize slots_lock aquisition during Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D09E1FF.9040408@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox