From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Thu, 16 Dec 2010 09:55:11 +0000 Subject: Re: [PATCH 2/3] KVM: Centralize slots_lock aquisition during KVM_CREATE_IRQCHIP Message-Id: <4D09E1FF.9040408@redhat.com> List-Id: References: <20101216014326.9210211a.takuya.yoshikawa@gmail.com> In-Reply-To: <20101216014326.9210211a.takuya.yoshikawa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org On 12/16/2010 11:47 AM, Takuya Yoshikawa wrote: >> They're under srcu now, the comments are outdated. >> >> We used to have slots_lock be a rwsem, taken for read or write as >> necessary. Now we use srcu for read, and the slots_lock mutex + >> synchronize_srcu for write. >> > > > Ah, would you mind updating the comments? > - or just removing outdated ones? > > Fixing the comments would be good. > I will reread these locking based on your answer! > One day I'll write Documentation/kvm/locking.txt, so it could get outdated as well. -- error compiling committee.c: too many arguments to function