From: Paolo Bonzini <pbonzini@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH v13 2/7] KVM: Add generic support for dirty page logging
Date: Fri, 07 Nov 2014 09:26:41 +0000 [thread overview]
Message-ID: <545C9051.5060401@redhat.com> (raw)
In-Reply-To: <1415320848-13813-3-git-send-email-m.smarduch@samsung.com>
On 07/11/2014 10:07, Cornelia Huck wrote:
>> > +#if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS) || \
>> > + defined(CONFIG_IA64) || defined(CONFIG_X86) || defined(CONFIG_ARM) || \
>> > + defined(CONFIG_ARM64)
> Does this deserve a config symbol that can be selected by architectures
> actually using kvm_get_dirty_log_protect()? I.e.,
>
> #ifndef CONFIG_KVM_ARCH_DIRTY_LOG_PROTECT
>
> or so?
Yes, either that or invert the #if to negative logic.
Paolo
next prev parent reply other threads:[~2014-11-07 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 0:40 [PATCH v13 2/7] KVM: Add generic support for dirty page logging Mario Smarduch
2014-11-07 9:07 ` Cornelia Huck
2014-11-07 9:26 ` Paolo Bonzini [this message]
2014-11-07 18:55 ` Mario Smarduch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545C9051.5060401@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox