From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Fri, 07 Nov 2014 09:26:41 +0000
Subject: Re: [PATCH v13 2/7] KVM: Add generic support for dirty page logging
Message-Id: <545C9051.5060401@redhat.com>
List-Id: <kvm-ia64.vger.kernel.org>
References: <1415320848-13813-3-git-send-email-m.smarduch@samsung.com>
In-Reply-To: <1415320848-13813-3-git-send-email-m.smarduch@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kvm-ia64@vger.kernel.org



On 07/11/2014 10:07, Cornelia Huck wrote:
>> > +#if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS) || \
>> > +    defined(CONFIG_IA64) || defined(CONFIG_X86) || defined(CONFIG_ARM) || \
>> > +    defined(CONFIG_ARM64)
> Does this deserve a config symbol that can be selected by architectures
> actually using kvm_get_dirty_log_protect()? I.e.,
> 
> #ifndef CONFIG_KVM_ARCH_DIRTY_LOG_PROTECT
> 
> or so?

Yes, either that or invert the #if to negative logic.

Paolo