From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Date: Thu, 13 Mar 2008 02:36:15 +0000 Subject: Re: [kvm-ppc-devel] [PATCH 3 of 7] Create new load_uboot() & gunzip Message-Id: <1205375775.9736.17.camel@basalt> List-Id: References: <48651677b7d05254d6ac.1205297442@thinkpad.austin.ibm.com> In-Reply-To: <48651677b7d05254d6ac.1205297442@thinkpad.austin.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jerone Young Cc: kvm-ppc-devel@lists.sourceforge.net, kvm-devel@lists.sourceforge.net On Tue, 2008-03-11 at 23:50 -0500, Jerone Young wrote: > diff --git a/qemu/sysemu.h b/qemu/sysemu.h > --- a/qemu/sysemu.h > +++ b/qemu/sysemu.h > @@ -182,6 +182,9 @@ int load_elf(const char *filename, int64 > uint64_t *pentry, uint64_t *lowaddr, uint64_t *highaddr); > int load_aout(const char *filename, uint8_t *addr); > int load_uboot(const char *filename, target_ulong *ep, int *is_linux); > +int load_uboot_l(const char *filename, target_ulong *ep, > + target_ulong *la, target_ulong *loaded_image_size, > + int *is_linux); > #endif > > #ifdef HAS_AUDIO I don't like the "_l" name, nor "la". Without reading the code I have no idea what those mean. Can't you just update the other load_uboot() callers? There are only 4 of them... and while you're at it, you should rename the function to load_uimage(). Pass NULL for whatever you rename "la" to, just like "is_linux" is handled already. -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-ppc-devel mailing list kvm-ppc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel