Kernel KVM-PPC virtualization development
 help / color / mirror / Atom feed
From: ehrhardt@linux.vnet.ibm.com
To: kvm-ppc@vger.kernel.org
Subject: [kvm-ppc-devel] [PATCH] silence some pci/uic debugging in kvmppc
Date: Thu, 13 Mar 2008 13:24:40 +0000	[thread overview]
Message-ID: <12054146801128-git-send-email-ehrhardt@linux.vnet.ibm.com> (raw)

Subject: [PATCH] silence some pci/uic debugging in kvmppc userspace
From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>

This is deactivating  some debug message that would flood the console when
using working things with sigificant load e.g. virtio for nfs root.
While this patch is deactivating it the solution might also be to a) split
that debug prints of the original 4xx_pci.diff patch, guard that prinf's
with a DEBUG_PCI define and additionally set the default to be off.
Short: the default should be non verbose - Hollis this is your code what
do you prefer?

Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
---

[diffstat]
 ppc4xx_devs.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/qemu/hw/ppc4xx_devs.c b/qemu/hw/ppc4xx_devs.c
--- a/qemu/hw/ppc4xx_devs.c
+++ b/qemu/hw/ppc4xx_devs.c
@@ -33,7 +33,7 @@ extern FILE *logfile;
 
 //#define DEBUG_MMIO
 //#define DEBUG_UNASSIGNED
-#define DEBUG_UIC
+//#define DEBUG_UIC
 
 /*****************************************************************************/
 /* Generic PowerPC 4xx processor instanciation */
@@ -814,8 +814,8 @@ static int bamboo_pci_map_irq(PCIDevice 
     int slot = pci_dev->devfn >> 3;
 
     /* All pins from each slot are tied to a single board IRQ (2-5) */
-    printf("### %s: devfn %x irq %d -> %d\n", __func__,
-           pci_dev->devfn, irq_num, slot+1);
+    /* printf("### %s: devfn %x irq %d -> %d\n", __func__,
+           pci_dev->devfn, irq_num, slot+1); */
 
     /* XXX re-examine */
     return slot + 1;
@@ -823,7 +823,7 @@ static int bamboo_pci_map_irq(PCIDevice 
 
 static void bamboo_pci_set_irq(qemu_irq *pic, int irq_num, int level)
 {
-    printf("### %s: PCI irq %d, UIC irq %d\n", __func__, irq_num, 30 - irq_num);
+    /* printf("### %s: PCI irq %d, UIC irq %d\n", __func__, irq_num, 30 - irq_num); */
 
     /* XXX re-examine */
     qemu_set_irq(pic[30-irq_num], level);

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

                 reply	other threads:[~2008-03-13 13:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12054146801128-git-send-email-ehrhardt@linux.vnet.ibm.com \
    --to=ehrhardt@linux.vnet.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox