From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Date: Mon, 09 Jun 2008 20:51:37 +0000 Subject: Re: [PATCH] [v5] Add gdb break point support to PowerPC kvm Message-Id: <1213044697.3358.24.camel@localhost.localdomain> List-Id: References: <1664758e846c292f5882.1213035589@thinkpadL> In-Reply-To: <1664758e846c292f5882.1213035589@thinkpadL> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: kvm-ppc@vger.kernel.org On Mon, 2008-06-09 at 13:19 -0500, Jerone Young wrote: > 4 files changed, 128 insertions(+), 2 deletions(-) > arch/powerpc/kvm/booke_guest.c | 16 +++++ > arch/powerpc/kvm/booke_interrupts.S | 3=20 > arch/powerpc/kvm/powerpc.c | 106 ++++++++++++++++++++++++++++++= ++++- > include/asm-powerpc/kvm_host.h | 5 + >=20 >=20 > * Boiled down conditional for dbsr to one line, when handling debug inte= rrupts. > Renamed load_guest_debug_registers() to guest_load_debug_registers() >=20 > This patch adds the ability to use breakpoints from a gdb stub in userpac= e (currently qemu). It does this through the use of hardware debug register= s. >=20 > Signed-off-by: Jerone Young =EF=BB=BFYou still have not renamed restore_host_debug_state() and guest_load_debug_registers(), which you agreed to previously. You still have not renamed guest_debug(), which you also agreed to previously. I don't see why you have a separate function for this anyways. You also have not addressed the case I pointed out where an IAC matches after you've programmed it but before you've entered the guest. --=20 Hollis Blanchard IBM Linux Technology Center