From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Date: Thu, 08 Dec 2011 05:31:44 +0000 Subject: Re: [PATCH 08/28] kvm tools: Fix KVM_RUN exit code check Message-Id: <1323322304.3904.6.camel@lappy> List-Id: References: <4EDD8E82.1010909@ozlabs.org> <1323159768.3882.9.camel@lappy> <4EE028E5.7080207@ozlabs.org> In-Reply-To: <4EE028E5.7080207@ozlabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matt Evans Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org On Thu, 2011-12-08 at 14:03 +1100, Matt Evans wrote: > Hi Sasha, > > On 06/12/11 19:22, Sasha Levin wrote: > > If KVM_RUN can actually return anything besides 0 or -1 it may be also > > worthwhile to update Documentation/virtual/kvm/api.txt . > > > > What are the cases where it happens? > > It sounds like Alex is considering KVM PPC's return value in this case (and > updating api.txt if appropriate) -- what say you on this patch? It actually > brings kvmtool's KVM_RUN return val check in line with QEMU's (also "< 0") and > nothing PPC will run without it, currently. (I'm about to repost a new series, > will include it for these reasons, until I hear more complaint ;) ) '<0' is fine as it's what api.txt says :) -- Sasha.