From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alistair Popple Date: Mon, 22 Mar 2021 09:20:05 +0000 Subject: Re: [PATCH v6 1/8] mm: Remove special swap entry functions Message-Id: <13488904.3iE9EkMCc7@nvdebian> List-Id: References: <20210312083851.15981-1-apopple@nvidia.com> <20210312083851.15981-2-apopple@nvidia.com> <20210315072757.GA4136862@infradead.org> In-Reply-To: <20210315072757.GA4136862@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: linux-mm@kvack.org, nouveau@lists.freedesktop.org, bskeggs@redhat.com, akpm@linux-foundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, dri-devel@lists.freedesktop.org, jhubbard@nvidia.com, rcampbell@nvidia.com, jglisse@redhat.com, jgg@nvidia.com, daniel@ffwll.ch, willy@infradead.org On Monday, 15 March 2021 6:27:57 PM AEDT Christoph Hellwig wrote: > On Fri, Mar 12, 2021 at 07:38:44PM +1100, Alistair Popple wrote: > > Remove the migration and device private entry_to_page() and > > entry_to_pfn() inline functions and instead open code them directly. > > This results in shorter code which is easier to understand. > > I think this commit log should mention pfn_swap_entry_to_page() now. Will add. Thanks for the review. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >