From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Thu, 24 Jan 2013 18:22:20 +0000
Subject: Re: [PATCH][v2] KVM: PPC: add paravirt idle loop for 64-bit book E
Message-Id: <1359051740.24865.10@snotra>
List-Id: <kvm-ppc.vger.kernel.org>
References: <1358898883-16218-1-git-send-email-stuart.yoder@freescale.com>
In-Reply-To: <1358898883-16218-1-git-send-email-stuart.yoder@freescale.com>
	(from stuart.yoder@freescale.com on Tue Jan 22 17:54:43 2013)
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Stuart Yoder <stuart.yoder@freescale.com>
Cc: agraf@suse.de, benh@kernel.crashing.org, linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, Stuart Yoder <stuart.yoder@freescale.com>

On 01/22/2013 05:54:43 PM, Stuart Yoder wrote:
> +.macro BOOK3E_IDLE_LOOP
> +1:
> +	PPC_WAIT(0)
>  	b	1b
> +.endm
> +
> +.macro EPAPR_EV_IDLE_LOOP
> +idle_loop:
> +       LOAD_REG_IMMEDIATE(r11, EV_HCALL_TOKEN(EV_IDLE))
> +
> +.global epapr_ev_idle_start
> +epapr_ev_idle_start:
> +       li      r3, -1
> +       nop
> +       nop
> +       nop
> +       b       idle_loop
> +.endm
> +
> +BOOK3E_IDLE epapr_ev_idle, EPAPR_EV_IDLE_LOOP
> +
> +BOOK3E_IDLE book3e_idle BOOK3E_IDLE_LOOP

Why the comma after epapr_ev_idle but not after book3e_idle?

Also you have spaces where there should be tabs.

Otherwise looks good.

-Scott