Re: [PATCH v4 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC

Paul Mackerras
2013-04-16T03:59:51Z

On Mon, Apr 15, 2013 at 12:52:27PM -0500, Scott Wood wrote:
> On 04/15/2013 12:23:28 AM, Paul Mackerras wrote:
> >On Fri, Apr 12, 2013 at 07:08:47PM -0500, Scott Wood wrote:
> >> Enabling this capability connects the vcpu to the designated
> >in-kernel
> >> MPIC. Using explicit connections between vcpus and irqchips allows
> >> for flexibility, but the main benefit at the moment is that it
> >> simplifies the code -- KVM doesn't need vm-global state to remember
> >> which MPIC object is associated with this vm, and it doesn't need to
> >> care about ordering between irqchip creation and vcpu creation.
> >
> >This fails to link with CONFIG_KVM_MPIC=n with the following error:
> >
> >arch/powerpc/kvm/built-in.o: In function `.kvm_arch_vcpu_free':
> >(.text+0x94f0): undefined reference to `.kvmppc_mpic_disconnect_vcpu'
>
> Sigh, forgot the ifdef again. :-(

Or you could define an empty static inline function in the
CONFIG_KVM_MPIC=n case, which looks a little nicer at the point of
use.

Paul.