From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Thu, 21 Mar 2013 14:43:01 +0000 Subject: Re: [RFC PATCH 6/6] kvm/ppc/mpic: in-kernel MPIC emulation Message-Id: <1363876981.31522.2@snotra> List-Id: References: <1360820960-12537-1-git-send-email-scottwood@freescale.com> <1360820960-12537-7-git-send-email-scottwood@freescale.com> In-Reply-To: (from agraf@suse.de on Thu Mar 21 03:28:35 2013) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org On 03/21/2013 03:28:35 AM, Alexander Graf wrote: > > On 14.02.2013, at 06:49, Scott Wood wrote: > > > Hook the MPIC code up to the KVM interfaces, add locking, etc. > > > > TODO: irqfd support > > > > Signed-off-by: Scott Wood > > Could you please split this patch up on your next respin? Any particular split you're looking for? The only reason it's split as much as it is already is to give some chance of merging updates from QEMU being less painful. As far as the kernel is concerned, this is new code, which is not functional (and thus not built) before this patch. There aren't meaningful intermediate states. > Also please make sure you don't have #if 0'ed code in here. Well, yeah. Note the RFC. :-) -Scott