From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 27 Mar 2013 17:50:34 +0000 Subject: Re: [PATCH 5/7 v2] KVM: PPC: e500: Remove E.PT and E.HV.LRAT categories from VCPUs Message-Id: <1364406634.31930.6@snotra> List-Id: References: <1364335512-28426-1-git-send-email-mihai.caraman@freescale.com> <1364335512-28426-6-git-send-email-mihai.caraman@freescale.com> In-Reply-To: <1364335512-28426-6-git-send-email-mihai.caraman@freescale.com> (from mihai.caraman@freescale.com on Tue Mar 26 17:05:10 2013) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mihai Caraman Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Mihai Caraman On 03/26/2013 05:05:10 PM, Mihai Caraman wrote: > Embedded.Page Table (E.PT) category in VMs requires indirect tlb > entries > emulation which is not supported yet. Configure TLBnCFG to remove E.PT > and E.HV.LRAT categories from VCPUs. > > Signed-off-by: Mihai Caraman > --- > v2: > - Remove E.HV.LRAT from vcpus > > arch/powerpc/kvm/e500_mmu.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/kvm/e500_mmu.c b/arch/powerpc/kvm/e500_mmu.c > index cf60db1..0d2a293 100644 > --- a/arch/powerpc/kvm/e500_mmu.c > +++ b/arch/powerpc/kvm/e500_mmu.c > @@ -867,11 +867,17 @@ static int vcpu_mmu_init(struct kvm_vcpu *vcpu, > vcpu->arch.tlbcfg[1] |= params[1].ways << TLBnCFG_ASSOC_SHIFT; > > if (has_feature(vcpu, VCPU_FTR_MMU_V2)) { > + vcpu->arch.mmucfg &= ~MMUCFG_LRAT; > + > if (has_feature(vcpu, VCPU_FTR_E_PT)) > vcpu->arch.eptcfg = mfspr(SPRN_EPTCFG); > else > vcpu->arch.eptcfg = 0; > > + /* Guest mmu emulation currently doesn't handle E.PT */ > + vcpu->arch.tlbcfg[0] &= ~TLBnCFG_PT; > + vcpu->arch.tlbcfg[1] &= ~TLBnCFG_IND; You're clearing these bits *after* calling has_feature() -- doesn't has_feature() depend on those bits being cleared to not advertise E_PT support? -Scott