Re: [RFC PATCH v3 1/6] kvm: add device control API

Scott Wood
2013-04-09T00:50:10Z

On 04/08/2013 12:33:13 AM, Paul Mackerras wrote:
> On Tue, Apr 02, 2013 at 08:57:48PM -0500, Scott Wood wrote:
>
> [snip]
>
> > +static int kvm_ioctl_create_device(struct kvm *kvm,
> > + struct kvm_create_device *cd)
> > +{
> > + bool test = cd->flags & KVM_CREATE_DEVICE_TEST;
> > +
> > + switch (cd->type) {
> > + default:
> > + return -ENODEV;
> > + }
> > +}
>
> This gives a compile error saying "error: unused variable `test'",
> which is fatal since this gets compiled under arch/powerpc/kvm, and we
> treat all warnings as errors there.
>
> This still gives a compile error at the end of your series if you try
> to compile with CONFIG_KVM_MPIC=n.

Ah, right. Will mark as __maybe_unused.

-Scott