Re: [PATCH 5/7] KVM: Extract generic irqchip logic into irqchip.c

Alexander Graf
2013-04-17T12:06:19Z

On 17.04.2013, at 14:05, Paolo Bonzini wrote:

> Il 16/04/2013 19:26, Alexander Graf ha scritto:
>> +#ifdef kvm_irqchip
>> TP_printk("irqchip %s pin %u",
>> __print_symbolic(__entry->irqchip, kvm_irqchips),
>> __entry->pin)
>> +#else
>> + TP_printk("irqchip %d pin %u", __entry->irqchip, __entry->pin)
>> +#endif
>
> Ah, spotted this too. Must be "#ifdef kvm_irqchips", but perhaps you
> can just use #ifdef __KVM_HAVE_IOAPIC.

Oops, nice catch!

I mostly wanted to #ifdef on kvm_irqchip so that another arch could add its own strings if it wants to :).

Alex