Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

Alexander Graf
2013-04-17T12:16:59Z

On 17.04.2013, at 14:15, Paolo Bonzini wrote:

> Il 17/04/2013 14:10, Alexander Graf ha scritto:
>>>> Still, __KVM_HAVE_IRQCHIP is clearly a subset of
>>>> __KVM_HAVE_IOAPIC; defining one without the other makes no sense
>>>> and will cause compilation or link errors for trace_kvm_ack_irq.
>>>>
>>>> Either we drop it altogether, or we should not break compilation
>>>> consciously---especially if the problem is so trivial and obvious
>>>> that you had to think of leaving it out.
>> I disagree. I actually _want_ to break it on purpose, so we have even
>> more reason to remove all that useless code if nobody complains.
>
> Then remove it in patch 1, and move all the remaining IOAPIC code back
> to arch/x86 at the end. As things are, you're just leaving someone else
> to do the work (no matter if it is to fix it, or to zap it).

Gleb, Marcelo, any objections to me removing ia64?

Alex