Re: [PATCH 2/7] KVM: Introduce __KVM_HAVE_IRQCHIP

Alexander Graf
2013-04-17T11:59:11Z

On 17.04.2013, at 13:54, Paolo Bonzini wrote:

> Il 17/04/2013 13:53, Alexander Graf ha scritto:
>>>>>> arch/x86/include/uapi/asm/kvm.h | 1 +
>>>>>> include/linux/kvm_host.h | 4 ++--
>>>>>> include/uapi/linux/kvm.h | 2 +-
>>>>>> virt/kvm/eventfd.c | 6 +++---
>>>>>> 4 files changed, 7 insertions(+), 6 deletions(-)
>>>>
>>>> You need to touch arch/ia64 too. Yeah, it's likely broken but let's not
>>>> break it on purpose. :)
>> It depends on CONFIG_BROKEN, so I'd rather not touch it.
>
> Well, we just got a patch to make it at least compile,

That was really just Yang (blindly?) fixing an issue I pointed out on ARM. There is no kvm user space support for IA64. The kernel side has been KConfig depending on BROKEN for a year already:

commit a6bb7929677aacfce3f864c3cdacaa7d527945d5
Author: Avi Kivity <avi@redhat.com>
Date: Thu May 17 13:14:08 2012 +0300

KVM: ia64: Mark ia64 KVM as BROKEN

Practically all patches to ia64 KVM are build fixes; numerous warnings remain;
the last patch from the maintainer was committed more than three years ago. It
is clear that no one is using this thing.

Mark as BROKEN to ensure people don't get hit by pointless build problems.

Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

The only patch I could see myself doing in arch/ia64 is an rm -rf arch/ia64/kvm.

Alex