public inbox for kvm-ppc@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Cc: "kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>,
	Gleb Natapov <gleb@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Subject: [PATCH 5/6] kvm/ppc/mpic: fix missing unlock in set_base_addr()
Date: Thu, 02 May 2013 13:32:50 +0000	[thread overview]
Message-ID: <1367501571-15509-6-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1367501571-15509-1-git-send-email-agraf@suse.de>

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Add the missing unlock before return from function set_base_addr()
when disables the mapping.

Introduced by commit 5df554ad5b7522ea62b0ff9d5be35183494efc21
(kvm/ppc/mpic: in-kernel MPIC emulation)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/powerpc/kvm/mpic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c
index eaac187..2861ae9 100644
--- a/arch/powerpc/kvm/mpic.c
+++ b/arch/powerpc/kvm/mpic.c
@@ -1486,8 +1486,8 @@ static int set_base_addr(struct openpic *opp, struct kvm_device_attr *attr)
 
 	map_mmio(opp);
 
-	mutex_unlock(&opp->kvm->slots_lock);
 out:
+	mutex_unlock(&opp->kvm->slots_lock);
 	return 0;
 }
 
-- 
1.8.1.4


  parent reply	other threads:[~2013-05-02 13:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 13:32 [PULL 0/6] ppc patch queue 2013-05-02 for 3.10 Alexander Graf
2013-05-02 13:32 ` [PATCH 1/6] kvm/ppc/mpic: remove default routes from documentation Alexander Graf
2013-05-02 13:32 ` [PATCH 2/6] kvm/ppc/mpic: fix mmio region lists when multiple guests used Alexander Graf
2013-05-02 13:32 ` [PATCH 3/6] kvm/ppc/mpic: remove users Alexander Graf
2013-05-02 13:32 ` [PATCH 4/6] kvm/ppc: Hold srcu lock when calling kvm_io_bus_read/write Alexander Graf
2013-05-02 13:32 ` Alexander Graf [this message]
2013-05-02 13:32 ` [PATCH 6/6] KVM: PPC: Book3S: Add API for in-kernel XICS emulation Alexander Graf
2013-05-03  0:09 ` [PULL 0/6] ppc patch queue 2013-05-02 for 3.10 Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367501571-15509-6-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=gleb@redhat.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox