From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Fri, 03 May 2013 23:53:47 +0000 Subject: Re: [PATCH] kvm/ppc/booke64: Hard disable interrupts when entering the guest Message-Id: <1367625227.19391.16@snotra> List-Id: References: <1367624723-22456-1-git-send-email-scottwood@freescale.com> In-Reply-To: <1367624723-22456-1-git-send-email-scottwood@freescale.com> (from scottwood@freescale.com on Fri May 3 18:45:23 2013) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Scott Wood Cc: Alexander Graf , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Mihai Caraman On 05/03/2013 06:45:23 PM, Scott Wood wrote: > While we could just set PACA_IRQ_HARD_DIS after an exit to compensate, > instead hard-disable interrupts before entering the guest. This way, > we won't have to worry about interactions if we take an interrupt > during the guest entry code. While I don't see any obvious > interactions, it could change in the future (e.g. it would be bad if > the non-hv code were used on 64-bit or if 32-bit guest lazy interrupt > disabling, since the non-hv code changes IVPR among other things). s/32-bit guest lazy/32-bit gets lazy/ -Scott