From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Wed, 21 May 2014 07:24:22 +0000 Subject: Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO Message-Id: <1400657062.18653.2.camel@pasglop> List-Id: References: <1400574612-19411-1-git-send-email-gwshan@linux.vnet.ibm.com> <1400574612-19411-4-git-send-email-gwshan@linux.vnet.ibm.com> <537B3AA7.7040106@suse.de> <537B3C68.8080102@suse.de> <20140520114031.GA20397@shangw> <537B4015.7030404@suse.de> <20140520122147.GA26483@shangw> <537B49C9.4000302@suse.de> <20140520123914.GA28441@shangw> <1400631832.3986.154.camel@pasglop> <17FB3514-B4F0-437F-826F-C473AD4F139E@suse.de> In-Reply-To: <17FB3514-B4F0-437F-826F-C473AD4F139E@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: "aik@ozlabs.ru" , Gavin Shan , "kvm-ppc@vger.kernel.org" , "alex.williamson@redhat.com" , "qiudayu@linux.vnet.ibm.com" , "linuxppc-dev@lists.ozlabs.org" On Wed, 2014-05-21 at 08:23 +0200, Alexander Graf wrote: > > Note to Alex: This definitely kills the notifier idea for now > though, > > at least as a first class citizen of the design. We can add it as an > > optional optimization on top later. > > I don't think it does. The notifier would just get triggered on config > space read failures for example :). It's really just an aid for the > vfio user to have a common code path for error handling. I'll let Gavin make the final call on that one, if he thinks we can reliably trigger it and there isn't too much code churn as a consequence. Cheers, Ben.