From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Date: Thu, 18 Jun 2015 09:15:26 +0000 Subject: Re: [PATCH 3/3] powerpc: add hvcall.h header from Linux Message-Id: <1434618926.18306.2.camel@ellerman.id.au> List-Id: References: <1434534230-17249-1-git-send-email-andre.przywara@arm.com> <1434534230-17249-4-git-send-email-andre.przywara@arm.com> <20150617101359.GC6303@arm.com> In-Reply-To: <20150617101359.GC6303@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Will Deacon Cc: Andre Przywara , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" , Vaidyanathan Srinivasan , Matt Evans On Wed, 2015-06-17 at 11:13 +0100, Will Deacon wrote: > On Wed, Jun 17, 2015 at 10:43:50AM +0100, Andre Przywara wrote: > > The powerpc code uses some PAPR hypercalls, of which we need the > > hypercall number. Copy the macro definition parts from the kernel's > > (private) hvcall.h file and remove the extra tricks formerly used > > to be able to include this header file directly. > > > > Signed-off-by: Andre Przywara > > --- > > Hi, > > > > I copied most of the Linux header, without removing > > definitions that kvmtool doesn't use. That should make updates > > easier. If people would prefer a bespoke header, let me know. > > I'd rather just #define the stuff we need now that we're outside of the > kernel source tree. Yeah that's probably cleaner. I think you only need: H_CPPR H_EOI H_FUNCTION H_GET_TERM_CHAR H_HARDWARE H_IPI H_LOGICAL_CACHE_LOAD H_LOGICAL_CACHE_STORE H_LOGICAL_CI_LOAD H_LOGICAL_CI_STORE H_LOGICAL_DCBF H_LOGICAL_ICBI H_PARAMETER H_PUT_TERM_CHAR H_SET_DABR H_SUCCESS H_XIRR KVMPPC_H_RTAS cheers