From: Michael Ellerman <mpe@ellerman.id.au>
To: Andre Przywara <andre.przywara@arm.com>
Cc: will.deacon@arm.com, Matt Evans <matt@ozlabs.org>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] kvmtool: Makefile: allow overriding CC and LD
Date: Fri, 19 Jun 2015 01:14:54 +0000 [thread overview]
Message-ID: <1434676494.23771.2.camel@ellerman.id.au> (raw)
In-Reply-To: <1434642647-3127-1-git-send-email-andre.przywara@arm.com>
On Thu, 2015-06-18 at 16:50 +0100, Andre Przywara wrote:
> Currently we set CC unconditionally to ${CROSS_COMPILE}gcc, the same
> for LD.
> Allow people to override the compiler name by specifying it explicitly
> on the command line or via the environment.
> Beside calling a certain compiler binary this allows to pass in
> options to the compiler, which lets us get rid of the PowerPC
> overrides in the Makefile. Possible uses:
> $ make CC="gcc -m64" LD="ld -melf64ppc"
> (build kvmtool on a PowerPC toolchain defaulting to 32-bit)
> $ make CC="gcc -m32" LD="ld -melf_i386"
> (build a 32-bit binary on a multilib-enabled x86-64 compiler)
I'm not a big fan of that.
Your examples are all about overriding CFLAGS and LDFLAGS, not CC and LD. So
if anything you should be allowing that. Adding flags to CC and LD is asking
for trouble.
cheers
next prev parent reply other threads:[~2015-06-19 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 15:50 [PATCH] kvmtool: Makefile: allow overriding CC and LD Andre Przywara
2015-06-19 1:14 ` Michael Ellerman [this message]
2015-06-19 10:00 ` Andre Przywara
2015-06-19 9:59 ` Paolo Bonzini
2015-06-19 10:23 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434676494.23771.2.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=andre.przywara@arm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=matt@ozlabs.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox